summaryrefslogtreecommitdiffhomepage
path: root/error.cpp
diff options
context:
space:
mode:
authorRoland Reichwein <mail@reichwein.it>2023-01-26 19:14:05 +0100
committerRoland Reichwein <mail@reichwein.it>2023-01-26 19:14:05 +0100
commitfd3da82dd7772419c01bb751e5b5cb7f198b4752 (patch)
treea22034831ec31df68b4e9cb22a1c51949e41b613 /error.cpp
parent9b0320c8b47c43adce1aa5d9821b67c1fa42e1d6 (diff)
websocket bugfix: socket leak
Diffstat (limited to 'error.cpp')
-rw-r--r--error.cpp32
1 files changed, 0 insertions, 32 deletions
diff --git a/error.cpp b/error.cpp
deleted file mode 100644
index d7a26de..0000000
--- a/error.cpp
+++ /dev/null
@@ -1,32 +0,0 @@
-#include "error.h"
-
-#include <iostream>
-
-#include <boost/asio/ssl/error.hpp>
-
-// Report a failure
-void fail(boost::beast::error_code ec, char const* what)
-{
- // ssl::error::stream_truncated, also known as an SSL "short read",
- // indicates the peer closed the connection without performing the
- // required closing handshake (for example, Google does this to
- // improve performance). Generally this can be a security issue,
- // but if your communication protocol is self-terminated (as
- // it is with both HTTP and WebSocket) then you may simply
- // ignore the lack of close_notify.
- //
- // https://github.com/boostorg/beast/issues/38
- //
- // https://security.stackexchange.com/questions/91435/how-to-handle-a-malicious-ssl-tls-shutdown
- //
- // When a short read would cut off the end of an HTTP message,
- // Beast returns the error beast::http::error::partial_message.
- // Therefore, if we see a short read here, it has occurred
- // after the message has been completed, so it is safe to ignore it.
-
- if (ec == boost::asio::ssl::error::stream_truncated)
- return;
-
- std::cerr << what << ": " << ec.message() << "\n";
-}
-